Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get corePkgVersion from github workflow job output instead of package.json #37875

Merged
merged 1 commit into from
Mar 15, 2022
Merged

Get corePkgVersion from github workflow job output instead of package.json #37875

merged 1 commit into from
Mar 15, 2022

Conversation

kvchari
Copy link
Contributor

@kvchari kvchari commented Mar 14, 2022

No description provided.

@kvchari kvchari force-pushed the fix-npm-vers branch 15 times, most recently from 283d1a9 to dbd1c90 Compare March 14, 2022 23:41
@kvchari kvchari changed the title Fix npm vers Get corePkgVersion from github workflow job output instead of package.json Mar 15, 2022
@kvchari kvchari requested a review from estherkim March 15, 2022 15:33
@kvchari kvchari marked this pull request as ready for review March 15, 2022 15:33
@kvchari kvchari enabled auto-merge (squash) March 15, 2022 15:33
estherkim
estherkim approved these changes Mar 15, 2022
View reviewed changes
.github/workflows/publish-npm-packages.yml Outdated Show resolved Hide resolved
@kvchari kvchari merged commit 419d49d into ampproject:main Mar 15, 2022
@kvchari kvchari deleted the fix-npm-vers branch March 15, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estherkim estherkim estherkim approved these changes

Assignees
No one assigned
Labels
PR use: In Beta / Experimental PR use: In LTS PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kvchari @estherkim @ampprojectbot